- Notifications
You must be signed in to change notification settings - Fork 84
Added kotlin compiler arguments support #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added kotlin compiler arguments support #872
Conversation
KotlinTranslatableCompiler.JS -> kotlinProjectExecutor.convertToJsIr(project) | ||
KotlinTranslatableCompiler.WASM -> kotlinProjectExecutor.convertToWasm(project, debugInfo) | ||
KotlinTranslatableCompiler.COMPOSE_WASM -> kotlinProjectExecutor.convertToWasm(project, debugInfo) | ||
class CompilerRestController( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zoobestik please, check the contract of this controller. If it suits you.
26d34af
to 5809835
Compare 8fd7307
to 4f2f724
Compare We are using `kotlin-compiler-arguments-description` maven dependency for extracting all known compiler arguments for the current kotlin version. We've added an endpoint for getting all known compiler dependencies by the given platform. We've extended `run` and `translate` endpoints with the user's compiler args.
5809835
to 4dd02f7
Compare "Xklib-ir-inliner" | ||
) | ||
| ||
private val ALLOWED_JS_ARGUMENTS = setOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilgonmic could you please check the white list for wasm and js arguments: ALLOWED_JS_ARGUMENTS, ALLOWED_WASM_ARGUMENTS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @JSMonk
src/main/kotlin/com/compiler/server/utils/CompilerArgumentsUtil.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/compiler/server/utils/CompilerArgumentsUtil.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/compiler/server/utils/CompilerArgumentsUtil.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/compiler/server/utils/CompilerArgumentsUtil.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/compiler/server/utils/CompilerArgumentsUtil.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/compiler/server/utils/CompilerArgumentsUtil.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/compiler/server/utils/CompilerArgumentsUtil.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/compiler/server/utils/CompilerArgumentsUtil.kt Outdated Show resolved Hide resolved
"Xklib-ir-inliner" | ||
) | ||
| ||
private val ALLOWED_JS_ARGUMENTS = setOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @JSMonk
"Xoptimize-generated-js" | ||
) | ||
| ||
private val ALLOWED_WASM_ARGUMENTS = setOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @bashor
63639d6
to bf4129f
Compare
No description provided.