Skip to content

Fix setting null value in query params with style "form" #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adascal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix setting null value in query params with style "form" #478

adascal wants to merge 1 commit into from

Conversation

@adascal
Copy link

@adascal adascal commented Nov 14, 2022

Because in js typeof null === 'object' we need additional check, otherwise Object.entries(args[saneParamName]) will fail with:

TypeError: Cannot convert undefined or null to object
@adascal
Fix setting null value in query params with style "form"
bd9d2fe 
Signed-off-by: Alexandr Dascal <a.dascal@semrush.com>
@adascal adascal force-pushed the fix/setting-null-param-in-form-style branch from 654117d to bd9d2fe Compare November 14, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@adascal