Fix ResolvedKeySpacePath.equals and hashCode #3591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Required tests on PathValue too
ScottDugas commented Sep 15, 2025
.../java/com/apple/foundationdb/record/provider/foundationdb/keyspace/ResolvedKeySpacePath.java Outdated Show resolved Hide resolved
ScottDugas requested review from ohadzeliger and removed request for alecgrieser 
ohadzeliger requested changes Sep 19, 2025
...main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/KeySpacePathImpl.java Outdated Show resolved Hide resolved
.../java/com/apple/foundationdb/record/provider/foundationdb/keyspace/ResolvedKeySpacePath.java Show resolved Hide resolved
...rc/test/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/PathValueTest.java Show resolved Hide resolved
...a/com/apple/foundationdb/record/provider/foundationdb/keyspace/ResolvedKeySpacePathTest.java Show resolved Hide resolved
...a/com/apple/foundationdb/record/provider/foundationdb/keyspace/ResolvedKeySpacePathTest.java Outdated Show resolved Hide resolved
...a/com/apple/foundationdb/record/provider/foundationdb/keyspace/ResolvedKeySpacePathTest.java Show resolved Hide resolved
This will be useful when comparing paths, because they can validate the parent, and don't care about the directiory's other children.
ohadzeliger approved these changes Sep 25, 2025
ohadzeliger reviewed Sep 25, 2025
...ain/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/KeySpaceDirectory.java Show resolved Hide resolved
ohadzeliger reviewed Sep 25, 2025
...main/java/com/apple/foundationdb/record/provider/foundationdb/keyspace/KeySpacePathImpl.java Show resolved Hide resolved
ohadzeliger approved these changes Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes
ResolvedKeySpace.equalsandhashCodeso that they follow the spec and are consistent.Notably there were a few issues:
KeyType.BYTESPathValue, while equals looked at the value)PathValuedid not implementequals/hashCoderemainderwas not included.Fixes: #3594