- Notifications
You must be signed in to change notification settings - Fork 317
Make CSI plugin collect too much classpaths #9985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bric3 wants to merge 15 commits into master Choose a base branch from bdu/make-csi-consume-way-less
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `generateCallSiteJava` task can fail when trying to resolve dependencies that have constraints, that can be set by the constraints DSL or by Dependency Locking (lockfile). Indeed `CallSiteInstrumentationPlugin`'s `getProgramClasspath()` method is collecting classpaths from **all** `AbstractCompile` tasks, including `compileLatestDepForkedTestJava` and `compileLatestDepTestJava`, which can have conflicting version constraints E.g. in javax-servlet-3.0 - testImplementation required strictly 8.2.0.v20160908 - latestDepTestImplementation wanted 9.+ - Dependency locking enforced 9.4.58.v20250814 for latestDepForkedTestCompileClasspath,latestDepForkedTestRuntimeClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath
…time configurations.
The 'instrument' plugin changes destination around for now, it needs to be depended on for the time being.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~8022770591, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a dateFormat X axisFormat %s section tracing Agent [baseline] (1.097 s) : 0, 1096693 Total [baseline] (10.712 s) : 0, 10711828 Agent [candidate] (1.102 s) : 0, 1101982 Total [candidate] (10.782 s) : 0, 10782287 section appsec Agent [baseline] (1.287 s) : 0, 1286824 Total [baseline] (11.165 s) : 0, 11165386 Agent [candidate] (1.287 s) : 0, 1286990 Total [candidate] (11.202 s) : 0, 11202070 section iast Agent [baseline] (1.236 s) : 0, 1236076 Total [baseline] (11.197 s) : 0, 11196504 Agent [candidate] (1.239 s) : 0, 1239084 Total [candidate] (11.183 s) : 0, 11183053 section profiling Agent [baseline] (1.227 s) : 0, 1227217 Total [baseline] (11.087 s) : 0, 11087040 Agent [candidate] (1.231 s) : 0, 1230708 Total [candidate] (11.076 s) : 0, 11076129
gantt title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~8022770591, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.449 ms) : 0, 1449 crashtracking [candidate] (1.459 ms) : 0, 1459 BytebuddyAgent [baseline] (704.068 ms) : 0, 704068 BytebuddyAgent [candidate] (707.5 ms) : 0, 707500 GlobalTracer [baseline] (247.724 ms) : 0, 247724 GlobalTracer [candidate] (248.945 ms) : 0, 248945 AppSec [baseline] (32.202 ms) : 0, 32202 AppSec [candidate] (32.327 ms) : 0, 32327 Debugger [baseline] (64.034 ms) : 0, 64034 Debugger [candidate] (64.236 ms) : 0, 64236 Remote Config [baseline] (627.753 µs) : 0, 628 Remote Config [candidate] (651.958 µs) : 0, 652 Telemetry [baseline] (8.09 ms) : 0, 8090 Telemetry [candidate] (8.274 ms) : 0, 8274 Flare Poller [baseline] (3.651 ms) : 0, 3651 Flare Poller [candidate] (3.681 ms) : 0, 3681 section appsec crashtracking [baseline] (1.468 ms) : 0, 1468 crashtracking [candidate] (1.46 ms) : 0, 1460 BytebuddyAgent [baseline] (734.967 ms) : 0, 734967 BytebuddyAgent [candidate] (734.116 ms) : 0, 734116 GlobalTracer [baseline] (241.588 ms) : 0, 241588 GlobalTracer [candidate] (241.62 ms) : 0, 241620 IAST [baseline] (24.852 ms) : 0, 24852 IAST [candidate] (25.051 ms) : 0, 25051 AppSec [baseline] (174.891 ms) : 0, 174891 AppSec [candidate] (175.087 ms) : 0, 175087 Debugger [baseline] (61.011 ms) : 0, 61011 Debugger [candidate] (61.405 ms) : 0, 61405 Remote Config [baseline] (675.612 µs) : 0, 676 Remote Config [candidate] (693.433 µs) : 0, 693 Telemetry [baseline] (8.378 ms) : 0, 8378 Telemetry [candidate] (8.397 ms) : 0, 8397 Flare Poller [baseline] (3.826 ms) : 0, 3826 Flare Poller [candidate] (3.994 ms) : 0, 3994 section iast crashtracking [baseline] (1.443 ms) : 0, 1443 crashtracking [candidate] (1.458 ms) : 0, 1458 BytebuddyAgent [baseline] (827.4 ms) : 0, 827400 BytebuddyAgent [candidate] (829.83 ms) : 0, 829830 GlobalTracer [baseline] (237.718 ms) : 0, 237718 GlobalTracer [candidate] (238.656 ms) : 0, 238656 IAST [baseline] (30.269 ms) : 0, 30269 IAST [candidate] (30.309 ms) : 0, 30309 AppSec [baseline] (31.333 ms) : 0, 31333 AppSec [candidate] (31.251 ms) : 0, 31251 Debugger [baseline] (61.391 ms) : 0, 61391 Debugger [candidate] (61.017 ms) : 0, 61017 Remote Config [baseline] (549.154 µs) : 0, 549 Remote Config [candidate] (551.958 µs) : 0, 552 Telemetry [baseline] (7.645 ms) : 0, 7645 Telemetry [candidate] (7.681 ms) : 0, 7681 Flare Poller [baseline] (3.472 ms) : 0, 3472 Flare Poller [candidate] (3.479 ms) : 0, 3479 section profiling crashtracking [baseline] (1.441 ms) : 0, 1441 crashtracking [candidate] (1.432 ms) : 0, 1432 BytebuddyAgent [baseline] (729.301 ms) : 0, 729301 BytebuddyAgent [candidate] (731.712 ms) : 0, 731712 GlobalTracer [baseline] (221.73 ms) : 0, 221730 GlobalTracer [candidate] (222.922 ms) : 0, 222922 AppSec [baseline] (32.253 ms) : 0, 32253 AppSec [candidate] (32.253 ms) : 0, 32253 Debugger [baseline] (62.82 ms) : 0, 62820 Debugger [candidate] (62.775 ms) : 0, 62775 Remote Config [baseline] (643.217 µs) : 0, 643 Remote Config [candidate] (651.241 µs) : 0, 651 Telemetry [baseline] (8.038 ms) : 0, 8038 Telemetry [candidate] (8.057 ms) : 0, 8057 Flare Poller [baseline] (3.759 ms) : 0, 3759 Flare Poller [candidate] (3.75 ms) : 0, 3750 ProfilingAgent [baseline] (97.554 ms) : 0, 97554 ProfilingAgent [candidate] (97.348 ms) : 0, 97348 Profiling [baseline] (98.137 ms) : 0, 98137 Profiling [candidate] (97.945 ms) : 0, 97945 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~8022770591, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a dateFormat X axisFormat %s section tracing Agent [baseline] (1.098 s) : 0, 1098268 Total [baseline] (8.88 s) : 0, 8880308 Agent [candidate] (1.101 s) : 0, 1100694 Total [candidate] (8.868 s) : 0, 8867560 section iast Agent [baseline] (1.233 s) : 0, 1233250 Total [baseline] (9.544 s) : 0, 9543913 Agent [candidate] (1.235 s) : 0, 1235330 Total [candidate] (9.563 s) : 0, 9563321
gantt title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~8022770591, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.461 ms) : 0, 1461 crashtracking [candidate] (1.455 ms) : 0, 1455 BytebuddyAgent [baseline] (705.175 ms) : 0, 705175 BytebuddyAgent [candidate] (706.78 ms) : 0, 706780 GlobalTracer [baseline] (248.728 ms) : 0, 248728 GlobalTracer [candidate] (249.022 ms) : 0, 249022 AppSec [baseline] (32.245 ms) : 0, 32245 AppSec [candidate] (32.315 ms) : 0, 32315 Debugger [baseline] (63.418 ms) : 0, 63418 Debugger [candidate] (63.697 ms) : 0, 63697 Remote Config [baseline] (635.166 µs) : 0, 635 Remote Config [candidate] (638.355 µs) : 0, 638 Telemetry [baseline] (8.117 ms) : 0, 8117 Telemetry [candidate] (8.26 ms) : 0, 8260 Flare Poller [baseline] (3.649 ms) : 0, 3649 Flare Poller [candidate] (3.676 ms) : 0, 3676 section iast crashtracking [baseline] (1.456 ms) : 0, 1456 crashtracking [candidate] (1.451 ms) : 0, 1451 BytebuddyAgent [baseline] (826.724 ms) : 0, 826724 BytebuddyAgent [candidate] (827.913 ms) : 0, 827913 GlobalTracer [baseline] (237.298 ms) : 0, 237298 GlobalTracer [candidate] (237.912 ms) : 0, 237912 IAST [baseline] (28.051 ms) : 0, 28051 IAST [candidate] (27.497 ms) : 0, 27497 AppSec [baseline] (33.225 ms) : 0, 33225 AppSec [candidate] (34.071 ms) : 0, 34071 Debugger [baseline] (60.05 ms) : 0, 60050 Debugger [candidate] (59.987 ms) : 0, 59987 Remote Config [baseline] (546.88 µs) : 0, 547 Remote Config [candidate] (529.811 µs) : 0, 530 Telemetry [baseline] (7.622 ms) : 0, 7622 Telemetry [candidate] (7.639 ms) : 0, 7639 Flare Poller [baseline] (3.444 ms) : 0, 3444 Flare Poller [candidate] (3.489 ms) : 0, 3489 LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~8022770591, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a dateFormat X axisFormat %s section baseline no_agent (1.2 ms) : 1188, 1212 . : milestone, 1200, iast (3.264 ms) : 3219, 3308 . : milestone, 3264, iast_FULL (5.815 ms) : 5757, 5873 . : milestone, 5815, iast_GLOBAL (3.619 ms) : 3542, 3696 . : milestone, 3619, profiling (2.155 ms) : 2136, 2175 . : milestone, 2155, tracing (1.817 ms) : 1801, 1832 . : milestone, 1817, section candidate no_agent (1.182 ms) : 1171, 1194 . : milestone, 1182, iast (3.32 ms) : 3276, 3365 . : milestone, 3320, iast_FULL (5.636 ms) : 5581, 5691 . : milestone, 5636, iast_GLOBAL (3.686 ms) : 3600, 3773 . : milestone, 3686, profiling (2.042 ms) : 2023, 2061 . : milestone, 2042, tracing (1.804 ms) : 1789, 1819 . : milestone, 1804,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~8022770591, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a dateFormat X axisFormat %s section baseline no_agent (19.356 ms) : 19157, 19555 . : milestone, 19356, appsec (19.276 ms) : 19080, 19472 . : milestone, 19276, code_origins (17.658 ms) : 17485, 17832 . : milestone, 17658, iast (17.938 ms) : 17760, 18117 . : milestone, 17938, profiling (19.666 ms) : 19468, 19865 . : milestone, 19666, tracing (17.892 ms) : 17714, 18070 . : milestone, 17892, section candidate no_agent (18.639 ms) : 18440, 18838 . : milestone, 18639, appsec (18.922 ms) : 18727, 19117 . : milestone, 18922, code_origins (17.623 ms) : 17446, 17799 . : milestone, 17623, iast (17.811 ms) : 17633, 17989 . : milestone, 17811, profiling (18.687 ms) : 18500, 18875 . : milestone, 18687, tracing (17.823 ms) : 17644, 18001 . : milestone, 17823,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~8022770591, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a dateFormat X axisFormat %s section baseline no_agent (14.914 s) : 14914000, 14914000 . : milestone, 14914000, appsec (14.862 s) : 14862000, 14862000 . : milestone, 14862000, iast (18.046 s) : 18046000, 18046000 . : milestone, 18046000, iast_GLOBAL (17.869 s) : 17869000, 17869000 . : milestone, 17869000, profiling (14.631 s) : 14631000, 14631000 . : milestone, 14631000, tracing (14.756 s) : 14756000, 14756000 . : milestone, 14756000, section candidate no_agent (15.402 s) : 15402000, 15402000 . : milestone, 15402000, appsec (14.477 s) : 14477000, 14477000 . : milestone, 14477000, iast (18.429 s) : 18429000, 18429000 . : milestone, 18429000, iast_GLOBAL (18.15 s) : 18150000, 18150000 . : milestone, 18150000, profiling (15.139 s) : 15139000, 15139000 . : milestone, 15139000, tracing (14.819 s) : 14819000, 14819000 . : milestone, 14819000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~8022770591, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a dateFormat X axisFormat %s section baseline no_agent (1.475 ms) : 1463, 1486 . : milestone, 1475, appsec (3.708 ms) : 3487, 3930 . : milestone, 3708, iast (2.211 ms) : 2147, 2274 . : milestone, 2211, iast_GLOBAL (2.257 ms) : 2192, 2321 . : milestone, 2257, profiling (2.076 ms) : 2023, 2129 . : milestone, 2076, tracing (2.027 ms) : 1977, 2076 . : milestone, 2027, section candidate no_agent (1.477 ms) : 1466, 1489 . : milestone, 1477, appsec (3.713 ms) : 3494, 3932 . : milestone, 3713, iast (2.214 ms) : 2150, 2278 . : milestone, 2214, iast_GLOBAL (2.259 ms) : 2195, 2323 . : milestone, 2259, profiling (2.06 ms) : 2008, 2111 . : milestone, 2060, tracing (2.031 ms) : 1981, 2081 . : milestone, 2031,
|
This comment has been minimized.
This comment has been minimized.
Base automatically changed from bdu/do-not-include-latest-dep-classpath to master November 18, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Caution
Not ready for review
What Does This Do
Refactors the call-site-instrumentation plugin collects too much classpath, which may create various problems.
Instead, this PR tries to make the csi plugin collect the minimum, and makes it explicit if something else is needed.
Also this plugins needlessly declares its task during
project.afterEvaluateMotivation
Quality of life, correctness.
Follow-up
Related to
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]