- Notifications
You must be signed in to change notification settings - Fork 317
Drop the requirement of jvm environment variables for testJvm constraint #9968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bdu/drop-fromEnv-toolchain-restriction
Are you sure you want to change the base?
Drop the requirement of jvm environment variables for testJvm constraint #9968
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 54 metrics, 6 unstable metrics.
Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~501af3d457, baseline=1.56.0-SNAPSHOT~8ceb94de51 dateFormat X axisFormat %s section tracing Agent [baseline] (1.103 s) : 0, 1102543 Total [baseline] (8.85 s) : 0, 8850456 Agent [candidate] (1.117 s) : 0, 1117222 Total [candidate] (8.878 s) : 0, 8878293 section iast Agent [baseline] (1.241 s) : 0, 1240587 Total [baseline] (9.531 s) : 0, 9531049 Agent [candidate] (1.246 s) : 0, 1246139 Total [candidate] (9.547 s) : 0, 9547270
gantt title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~501af3d457, baseline=1.56.0-SNAPSHOT~8ceb94de51 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.482 ms) : 0, 1482 crashtracking [candidate] (1.472 ms) : 0, 1472 BytebuddyAgent [baseline] (709.0 ms) : 0, 709000 BytebuddyAgent [candidate] (714.46 ms) : 0, 714460 GlobalTracer [baseline] (249.257 ms) : 0, 249257 GlobalTracer [candidate] (250.973 ms) : 0, 250973 AppSec [baseline] (32.413 ms) : 0, 32413 AppSec [candidate] (32.792 ms) : 0, 32792 Debugger [baseline] (63.059 ms) : 0, 63059 Debugger [candidate] (69.443 ms) : 0, 69443 Remote Config [baseline] (637.952 µs) : 0, 638 Remote Config [candidate] (657.09 µs) : 0, 657 Telemetry [baseline] (8.197 ms) : 0, 8197 Telemetry [candidate] (8.472 ms) : 0, 8472 Flare Poller [baseline] (3.703 ms) : 0, 3703 Flare Poller [candidate] (3.826 ms) : 0, 3826 section iast crashtracking [baseline] (1.454 ms) : 0, 1454 crashtracking [candidate] (1.465 ms) : 0, 1465 BytebuddyAgent [baseline] (833.067 ms) : 0, 833067 BytebuddyAgent [candidate] (831.522 ms) : 0, 831522 GlobalTracer [baseline] (237.681 ms) : 0, 237681 GlobalTracer [candidate] (238.988 ms) : 0, 238988 IAST [baseline] (28.532 ms) : 0, 28532 IAST [candidate] (27.653 ms) : 0, 27653 AppSec [baseline] (33.327 ms) : 0, 33327 AppSec [candidate] (34.214 ms) : 0, 34214 Debugger [baseline] (60.004 ms) : 0, 60004 Debugger [candidate] (65.562 ms) : 0, 65562 Remote Config [baseline] (550.746 µs) : 0, 551 Remote Config [candidate] (558.589 µs) : 0, 559 Telemetry [baseline] (7.674 ms) : 0, 7674 Telemetry [candidate] (7.709 ms) : 0, 7709 Flare Poller [baseline] (3.475 ms) : 0, 3475 Flare Poller [candidate] (3.577 ms) : 0, 3577 Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~501af3d457, baseline=1.56.0-SNAPSHOT~8ceb94de51 dateFormat X axisFormat %s section tracing Agent [baseline] (1.096 s) : 0, 1095625 Total [baseline] (10.775 s) : 0, 10774615 Agent [candidate] (1.108 s) : 0, 1107883 Total [candidate] (10.8 s) : 0, 10799978 section appsec Agent [baseline] (1.283 s) : 0, 1282933 Total [baseline] (11.119 s) : 0, 11119309 Agent [candidate] (1.288 s) : 0, 1287583 Total [candidate] (11.241 s) : 0, 11241264 section iast Agent [baseline] (1.239 s) : 0, 1238533 Total [baseline] (9.552 s) : 0, 9551759 Agent [candidate] (1.258 s) : 0, 1257758 Total [candidate] (11.401 s) : 0, 11401287 section profiling Agent [baseline] (1.226 s) : 0, 1226359 Total [baseline] (11.023 s) : 0, 11023262 Agent [candidate] (1.24 s) : 0, 1239515 Total [candidate] (11.069 s) : 0, 11069008
gantt title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~501af3d457, baseline=1.56.0-SNAPSHOT~8ceb94de51 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.447 ms) : 0, 1447 crashtracking [candidate] (1.463 ms) : 0, 1463 BytebuddyAgent [baseline] (703.424 ms) : 0, 703424 BytebuddyAgent [candidate] (708.189 ms) : 0, 708189 GlobalTracer [baseline] (247.166 ms) : 0, 247166 GlobalTracer [candidate] (249.191 ms) : 0, 249191 AppSec [baseline] (32.241 ms) : 0, 32241 AppSec [candidate] (32.463 ms) : 0, 32463 Debugger [baseline] (64.231 ms) : 0, 64231 Debugger [candidate] (69.247 ms) : 0, 69247 Remote Config [baseline] (622.184 µs) : 0, 622 Remote Config [candidate] (641.989 µs) : 0, 642 Telemetry [baseline] (8.09 ms) : 0, 8090 Telemetry [candidate] (8.126 ms) : 0, 8126 Flare Poller [baseline] (3.692 ms) : 0, 3692 Flare Poller [candidate] (3.732 ms) : 0, 3732 section appsec crashtracking [baseline] (1.456 ms) : 0, 1456 crashtracking [candidate] (1.468 ms) : 0, 1468 BytebuddyAgent [baseline] (732.469 ms) : 0, 732469 BytebuddyAgent [candidate] (733.818 ms) : 0, 733818 GlobalTracer [baseline] (240.8 ms) : 0, 240800 GlobalTracer [candidate] (242.828 ms) : 0, 242828 IAST [baseline] (24.949 ms) : 0, 24949 IAST [candidate] (25.092 ms) : 0, 25092 AppSec [baseline] (174.554 ms) : 0, 174554 AppSec [candidate] (174.938 ms) : 0, 174938 Debugger [baseline] (60.997 ms) : 0, 60997 Debugger [candidate] (61.471 ms) : 0, 61471 Remote Config [baseline] (673.708 µs) : 0, 674 Remote Config [candidate] (666.841 µs) : 0, 667 Telemetry [baseline] (8.297 ms) : 0, 8297 Telemetry [candidate] (8.338 ms) : 0, 8338 Flare Poller [baseline] (3.908 ms) : 0, 3908 Flare Poller [candidate] (3.912 ms) : 0, 3912 section iast crashtracking [baseline] (1.448 ms) : 0, 1448 crashtracking [candidate] (1.482 ms) : 0, 1482 BytebuddyAgent [baseline] (831.095 ms) : 0, 831095 BytebuddyAgent [candidate] (839.369 ms) : 0, 839369 GlobalTracer [baseline] (237.641 ms) : 0, 237641 GlobalTracer [candidate] (240.646 ms) : 0, 240646 IAST [baseline] (28.549 ms) : 0, 28549 IAST [candidate] (30.547 ms) : 0, 30547 AppSec [baseline] (32.888 ms) : 0, 32888 AppSec [candidate] (31.61 ms) : 0, 31610 Debugger [baseline] (60.698 ms) : 0, 60698 Debugger [candidate] (67.207 ms) : 0, 67207 Remote Config [baseline] (543.056 µs) : 0, 543 Remote Config [candidate] (549.282 µs) : 0, 549 Telemetry [baseline] (7.679 ms) : 0, 7679 Telemetry [candidate] (7.718 ms) : 0, 7718 Flare Poller [baseline] (3.461 ms) : 0, 3461 Flare Poller [candidate] (3.522 ms) : 0, 3522 section profiling crashtracking [baseline] (1.444 ms) : 0, 1444 crashtracking [candidate] (1.45 ms) : 0, 1450 BytebuddyAgent [baseline] (728.964 ms) : 0, 728964 BytebuddyAgent [candidate] (733.529 ms) : 0, 733529 GlobalTracer [baseline] (222.024 ms) : 0, 222024 GlobalTracer [candidate] (223.185 ms) : 0, 223185 AppSec [baseline] (32.299 ms) : 0, 32299 AppSec [candidate] (32.414 ms) : 0, 32414 Debugger [baseline] (62.942 ms) : 0, 62942 Debugger [candidate] (68.54 ms) : 0, 68540 Remote Config [baseline] (652.239 µs) : 0, 652 Remote Config [candidate] (657.58 µs) : 0, 658 Telemetry [baseline] (7.955 ms) : 0, 7955 Telemetry [candidate] (8.029 ms) : 0, 8029 Flare Poller [baseline] (3.786 ms) : 0, 3786 Flare Poller [candidate] (3.79 ms) : 0, 3790 ProfilingAgent [baseline] (96.891 ms) : 0, 96891 ProfilingAgent [candidate] (97.826 ms) : 0, 97826 Profiling [baseline] (97.48 ms) : 0, 97480 Profiling [candidate] (98.397 ms) : 0, 98397 LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 17 unstable metrics. Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~501af3d457, baseline=1.56.0-SNAPSHOT~8ceb94de51 dateFormat X axisFormat %s section baseline no_agent (18.563 ms) : 18372, 18754 . : milestone, 18563, appsec (18.878 ms) : 18686, 19069 . : milestone, 18878, code_origins (17.78 ms) : 17603, 17957 . : milestone, 17780, iast (17.456 ms) : 17281, 17632 . : milestone, 17456, profiling (18.551 ms) : 18364, 18738 . : milestone, 18551, tracing (17.792 ms) : 17613, 17971 . : milestone, 17792, section candidate no_agent (18.957 ms) : 18760, 19153 . : milestone, 18957, appsec (18.697 ms) : 18508, 18885 . : milestone, 18697, code_origins (17.832 ms) : 17655, 18009 . : milestone, 17832, iast (17.674 ms) : 17499, 17849 . : milestone, 17674, profiling (18.85 ms) : 18661, 19038 . : milestone, 18850, tracing (17.488 ms) : 17317, 17660 . : milestone, 17488,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~501af3d457, baseline=1.56.0-SNAPSHOT~8ceb94de51 dateFormat X axisFormat %s section baseline no_agent (1.198 ms) : 1186, 1210 . : milestone, 1198, iast (3.279 ms) : 3245, 3313 . : milestone, 3279, iast_FULL (5.883 ms) : 5824, 5943 . : milestone, 5883, iast_GLOBAL (3.525 ms) : 3456, 3594 . : milestone, 3525, profiling (2.354 ms) : 2332, 2377 . : milestone, 2354, tracing (1.785 ms) : 1770, 1799 . : milestone, 1785, section candidate no_agent (1.188 ms) : 1176, 1200 . : milestone, 1188, iast (3.215 ms) : 3179, 3251 . : milestone, 3215, iast_FULL (5.864 ms) : 5804, 5924 . : milestone, 5864, iast_GLOBAL (3.462 ms) : 3408, 3515 . : milestone, 3462, profiling (2.317 ms) : 2292, 2342 . : milestone, 2317, tracing (1.81 ms) : 1795, 1825 . : milestone, 1810,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~501af3d457, baseline=1.56.0-SNAPSHOT~8ceb94de51 dateFormat X axisFormat %s section baseline no_agent (1.479 ms) : 1467, 1490 . : milestone, 1479, appsec (3.649 ms) : 3433, 3864 . : milestone, 3649, iast (2.215 ms) : 2151, 2279 . : milestone, 2215, iast_GLOBAL (2.265 ms) : 2200, 2329 . : milestone, 2265, profiling (2.07 ms) : 2019, 2122 . : milestone, 2070, tracing (2.017 ms) : 1967, 2066 . : milestone, 2017, section candidate no_agent (1.479 ms) : 1467, 1490 . : milestone, 1479, appsec (3.726 ms) : 3506, 3946 . : milestone, 3726, iast (2.217 ms) : 2153, 2281 . : milestone, 2217, iast_GLOBAL (2.262 ms) : 2197, 2326 . : milestone, 2262, profiling (2.095 ms) : 2041, 2149 . : milestone, 2095, tracing (2.029 ms) : 1979, 2079 . : milestone, 2029,
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~501af3d457, baseline=1.56.0-SNAPSHOT~8ceb94de51 dateFormat X axisFormat %s section baseline no_agent (14.912 s) : 14912000, 14912000 . : milestone, 14912000, appsec (14.823 s) : 14823000, 14823000 . : milestone, 14823000, iast (18.401 s) : 18401000, 18401000 . : milestone, 18401000, iast_GLOBAL (17.833 s) : 17833000, 17833000 . : milestone, 17833000, profiling (15.387 s) : 15387000, 15387000 . : milestone, 15387000, tracing (14.792 s) : 14792000, 14792000 . : milestone, 14792000, section candidate no_agent (15.187 s) : 15187000, 15187000 . : milestone, 15187000, appsec (14.809 s) : 14809000, 14809000 . : milestone, 14809000, iast (18.562 s) : 18562000, 18562000 . : milestone, 18562000, iast_GLOBAL (18.031 s) : 18031000, 18031000 . : milestone, 18031000, profiling (15.938 s) : 15938000, 15938000 . : milestone, 15938000, tracing (14.616 s) : 14616000, 14616000 . : milestone, 14616000,
|
| if (javaVersions.isEmpty()) { | ||
| throw GradleException("No valid JAVA_X_HOME environment variables found.") | ||
| when (testJvm) { | ||
| "stable" -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename stable -> latest? or similar? stable is kind of misleading to me, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant to that right now, as there were prior discussions on this.
Maybe we can have both, like lastStable :D
| * Handles the `testJvm` property to resolve a Java launcher for testing. | ||
| * | ||
| * The `testJvm` property can be set via command line or environment variable to specify | ||
| * which JVM to use for running tests. E.g. | ||
| * | ||
| * ```shell | ||
| * ./gradlew test -DtestJvm=ZULU11 | ||
| * ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we have TESTING.md with all this useful documentation from this class :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, I started the kdoc here, so we can reuse this text for such a file.
| * which JVM to use for running tests. E.g. | ||
| * | ||
| * ```shell | ||
| * ./gradlew test -DtestJvm=ZULU11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * ./gradlew test -DtestJvm=ZULU11 | |
| * ./gradlew test -PtestJvm=ZULU11 |
I think we should still be using -P here, since on line 44 below (project.providers.gradleProperty(TEST_JVM)), we are using testJvm as a Gradle project property (ref)
| Nice! |
What Does This Do
Allow our testJvmContraint plugin to let Gradle find the relevant JVM using the Gradle Toolchain.
Also, in CI, discover dynamically the JAVA_x_HOME environment variables exposed by the DataDog/dd-trace-java-docker-build image.
Motivation
Easier local setup. And follow-up to
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]