Update updateip.py #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
gregbo commented Mar 21, 2023
gregbo commented - take hostname, username, etc. from command line
- prompt for password
- check for errors and handle exceptions from requests
take hostname, username, etc. from command line prompt for password check for errors and handle exceptions from requests
| As promised, this update allows parameters such as the hostname, username, etc. to be supplied to the script. I can think of other desirable features, such as:
|
xorrkaz requested changes Mar 22, 2023
use raise_for_status() to handle requests exceptions
xorrkaz reviewed Mar 22, 2023
make management interface a command-line option w/default
use environment variable, if set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.