Added edit title and edit contributors tests #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The provided test command references tests/metadata.py, but the correct file name is test_metadata.py. |
felliott reviewed May 2, 2025
tests/test_metadata.py Outdated
| | ||
| new_title = fake.sentence(nb_words=2) | ||
| new_description = fake.sentence(nb_words=4) | ||
| original_title = 'Selenium Registration for Metadata tests' |
There was a problem hiding this comment.
If this is the same as ln. 499, perhaps it should be a constant?
There was a problem hiding this comment.
Updated title as constant
felliott approved these changes May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
Updated the selenium test suite to add new tests to registration metadata tests to include edit title and edit contributors tests.
Summary of Changes
Updated test_metadata.py to add edit title and edit contributors tests to RegistrationMetadata.
Updated registries.py page to include new methods for selecting item from table and selecting item from a list
Updated osf_api.py to include 2 new methods to update registration title and delete registration contributor
Updated utils.py to include new method to clean text
Reviewer's Actions
git fetch <remote> pull/282/head:feature/registration_metadata_fixRun this test using
pytest tests/metadata.py::TestRegistrationMetadata -s -vTesting Changes Moving Forward
Ticket
https://openscience.atlassian.net/browse/ENG-7681
https://openscience.atlassian.net/browse/ENG-7682