Skip to content

Conversation

Ramyapatil712
Copy link
Collaborator

@Ramyapatil712 Ramyapatil712 commented Feb 2, 2024

Purpose

Update our selenium test to add new navbar tests to collections discover page and project details page

Product team requested to add these tests to verify search, donate and support link on project details page and collections discover page.

Summary of Changes

For Collections-

  • Updated collections.py - added few locators for Search, Add to collections and Donate buttons
  • test_navbar.py — Added new classes TestCollectionsNavbarLoggedOut and TestCollectionsNavbarLoggedIn

For Project Details page

Updated test_navbar.py- Added new tests
navbars.py- Added locator for my_projects link

Reviewer's Actions

git fetch <remote> pull/262/head:feature/add-navbartests-to-collections-project

Run this test using
pytest tests/test_navbar.py::TestCollectionsNavbarLoggedIn -sv
pytest tests/test_navbar.py::TestCollectionsNavbarLoggedOut -sv
pytest tests/test_navbar.py::TestProjectsNavbarLoggedIn -sv

Testing Changes Moving Forward

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-5139

Copy link
Member

@felliott felliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks and a few questions. There are a few small style issues i didn't mention that will be fixed up by running isort and black.

@Ramyapatil712
Copy link
Collaborator Author

Ramyapatil712 commented Feb 5, 2024

@felliott , @jh27539 and @cslzchen Done all the changes suggested and used black for formatting. Please review the changes

@felliott felliott force-pushed the feature/add-navbartests-to-collections-project branch from 86b2736 to 6aefb45 Compare February 16, 2024 16:14
@jh27539 jh27539 merged commit 1e5dd8f into develop Mar 5, 2024
@jh27539 jh27539 deleted the feature/add-navbartests-to-collections-project branch March 5, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants