Skip to content

Conversation

mkovalua
Copy link

@mkovalua mkovalua commented Jul 31, 2025

Ticket

https://openscience.atlassian.net/browse/ENG-8423

Purpose

apply ruff and pre-commit for autoformatting to keep code style in one standart

Changes

setup needed packages,

apply ruff styling to existing mfr code usingruff format .command

add 'pre-commit' support to apply auto ruff formatting pre-commit install command run is needed on first run

image

Side effects

ruff tells about raise inside except, is it ok , if we change it somehow it may break some business logic?

image

QA Notes

Deployment Notes

@coveralls
Copy link

coveralls commented Jul 31, 2025

Coverage Status

coverage: 68.714%. remained the same
when pulling 5fd07dc on mkovalua:feature/ENG--8423
into 69b7309 on CenterForOpenScience:feature/buff-worms.

Copy link

@sh-andriy sh-andriy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

Copy link
Contributor

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a few suggestions ⭐

Copy link
Contributor

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎆 . As discussed, this will likely be post release. Keeping this PR and the ticket open for reference. We need to create a brand new PR once MFR is released.

@cslzchen cslzchen changed the title [ENG-8423] apply ruff and pre-commit for autoformatting [ENG-8423] [Reference PR] [Don't Merge] apply ruff and pre-commit for autoformatting Aug 7, 2025
@felliott felliott merged commit a080e58 into CenterForOpenScience:feature/buff-worms Aug 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants