[ENG-7601] Ext image ext ipy updates #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
futa-ikeda changed the title 
felliott force-pushed the ext-image-ext-ipy-updates branch from c430828 to 9eb5c7a Compare felliott merged commit adc4bc2 into CenterForOpenScience:feature/buff-worms 1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ticket
ENG-7601
Purpose
Changes
Side effects
pytest tests/extensions/xlrd==1.0.0which causesAttributeError: module 'time' has no attribute 'clock'(seems to be deprecated as of Python 3.3).Excel xlsx file; not supported. Seems xlrd is just focusing on xls files according to this SO postRuntimeError: There is no current event loop in thread 'MainThread'., but those will be handled in a separate PRQA Notes
Deployment Notes