Handle newer jasp files #372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…index.html" and show it
3 tasks
| Any chance this could be merged quickly? |
| Would there be any drawback to using the same approach as the jamovi PR? I'm prepping a release for that, and it seems like they might be similar. I'd kinda like to keep the extra validation, since a lot of file types are renamed zip files. I will test it locally with the jamovi fix (adding a check for the new manifest name), but is there anything else that I should be concerned about? Thank you! |
| The exact fix didn't work since the format of the manifest changed. I've adapted it a bit to still do some basic validation. This is merged into |
| This has been released! |
| It works great, merci |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
JASP files have been updated recently and could no longer be previewed on OSF.
Changes
This PR removes some superfluous check that allow the file renderer to show both old and new jasp-files. A new test case is added for newer files.