Handle newer jasp files #371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Ah @RensDofferhoff is asking me to open and close this repeatedly. Ill just close it for now. But testing changes to this repository is not trivial it seems |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
JASP files have been updated recently and could no longer be previewed on OSF.
Changes
This PR removes some superfluous check that allow the file renderer to show both old and new jasp-files.
Problems
Me and my colleague @RensDofferhoff tried running the tests and renderer locally to test this.
But the versions request are all ancient and we could not get test to fail and this detected.
In other words, this is untested but we have no idea how to get it tested.
The changes are rather minimal though so it should just work.