TDMS Renderer #364
Closed
TDMS Renderer #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Updates to render.py, tdms.css, tdms.js viewer.mako that render tdms files in HTML as well as light testing in test_renderer.py
| Hey @cbbcbail! Thanks for the PR! A quick request: can you move your work over to a local feature branch and update your PR to point there? If I end up rebasing any of your work, I would like to push to a non- Unfortunately I'm fighting a few fires ATM, so I don't think I will be able to review the PR this week. I will check back in with you on the 21st to let you know my review ETA. Sorry about that! Cheers, |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
TDMS Renderer
Purpose
To add support for tdms files in modular file renderer on osf.io
Changes
Addition of tdms renderer extension called when a tams file needs to be rendered.