[SVCS-699] Write a stable id into generated pdfs #338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
NyanHelsing changed the title 
NyanHelsing force-pushed the ft/stable-pdf-ids branch from a79e6c9 to 98d7c65 Compare NyanHelsing changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/secure/RapidBoard.jspa?rapidView=92&projectKey=SVCS&modal=detail&selectedIssue=SVCS-699
Purpose
Write a stable id into generated pdfs, so that hypothesis annotations stay the same even through multiple rerenders.
Changes
adds a requirement for pdfrw,
in the unoconv exporter, grab the ids for the original file and stick them into the pdf trailer on the id field.
Side effects
unoconv exporter may take more time
QA Notes
Check a bunch of pdfs and make sure they still convert properly
Deployment Notes