Skip to content

Conversation

NyanHelsing
Copy link
Contributor

@NyanHelsing NyanHelsing commented Apr 16, 2018

Purpose

Don't try and lint stuff in node_modules.

Changes

Adds node_modules to the iexclude list for flake8

Side effects

QA Notes

Deployment Notes

@NyanHelsing NyanHelsing changed the title Ignore node_modulse during lint Ignore node_modules during lint Apr 16, 2018
Copy link
Contributor

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM and merge after restarted tests pass 🎆 .

@coveralls
Copy link

coveralls commented Apr 16, 2018

Coverage Status

Coverage remained the same at 71.268% when pulling 3b807d0 on birdbrained:ft/ignore-node-modules into fc0d556 on CenterForOpenScience:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants