[HotFix] [SVCS-677] Fix Unsupported Export Type #328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cslzchen commented Apr 2, 2018
| | ||
| # `make_renderer()` is called before `make_exporter()` to ensure the file type is supported | ||
| # Empty list indicates unsupported export type. Return '' and let `make_exporter()` handle it. | ||
| if len(ep_list) == 0: |
There was a problem hiding this comment.
The fix follows exactly the same code used in get_renderer_name(). In addition, the comment is corrected.
felliott changed the title 
felliott requested changes Apr 2, 2018
| @felliott I updated both cases for |
cslzchen force-pushed the bug-fix/unsupported-exporter branch 2 times, most recently from 5155c22 to 249115d Compare 
Fixed the bug where unsupported export types throw 400 assertion error instead of 400 exporter error. Remove the misleading comment which wrongly claims that `get_exporter_name()` is always called with a supported exporter. Update tests accordingly.
- R/E: renderer name and exporter name - `get_render_name()` and `get_exporter_name()` return '' when rendering/exporting a given type is not supported. Update `cache_file_path` for both to be removed of the trailing dot
cslzchen force-pushed the bug-fix/unsupported-exporter branch from 249115d to ebc764e Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ticket
SVCS-677
Purpose
Fixed the bug where unsupported export types throw 400 assertion error instead of 400 exporter error. Remove the misleading comment which wrongly claims that
get_exporter_name()is always called with a supported exporter. Update tests accordingly.Changes
Before
After
Side effects
No
QA Notes
TBD
Deployment Notes
No