[SVCS-369] Catch SIGTERM and exit gracefully. #264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
"docker-compose stop" sends SIGTERM. This PR catches and handles the SIGTERM signal. Adapted from... https://gist.github.com/wonderbeyond/d38cd85243befe863cdde54b84505784 Per docker documentation https://docs.docker.com/engine/reference/run/ Note: A process running as PID 1 inside a container is treated specially by Linux: it ignores any signal with the default action. So, the process will not terminate on SIGINT or SIGTERM unless it is coded to do so.
TomBaxter changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose:
SVCS-369
"docker-compose stop" sends SIGTERM.
This PR catches and handles the SIGTERM signal.
Changes:
Update mfr/server/app.py
Side effects
None
[#SVCS-369]