[CR] remove some unneeded libraries #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* The converter and formatter modules MFR uses to render IPython notebooks have been split out into their own distributions, nbconvert and nbformat. Update the renderer to use these and drop the dependency on IPython as a whole.
* rpy2 was only being used to convert SPSS .sav files to a format pandas can handle. pspp-convert is a program that can convert .sav to .csv. Update the tabular renderer to use that instead. As a side effect, it turns out the standard csv library is better at detecting data types than pandas is, so use that to render the resulting csv file
| LGTM, manual testing revealed no issues ⭐ Consider adding something to the docs about configuring |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR removes deps on
IPythonandrpy2in favor of lighter-weight alternatives.