Skip to content

Throw exception for unknown canvas type instead create Image by def… #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Throw exception for unknown canvas type instead create Image by def… #1538

wants to merge 4 commits into from

Conversation

piranna
Copy link
Contributor

@piranna piranna commented Mar 21, 2020

…ault

Conflicts:

test/canvas.test.js

Thanks for contributing!

  • Have you updated CHANGELOG.md?
@piranna
Copy link
Contributor Author

piranna commented Aug 3, 2020

Can this be reviewed and merged? It's mostly a patch, but since change the current behaviour, maybe it should be added to the next major...
@piranna
Copy link
Contributor Author

piranna commented Oct 17, 2020

Code sync'ed with latest master branch and all tests are fixed and passing in all platforms. Can this pull-request be reviewed and merged? :-)
@zbjornson zbjornson force-pushed the master branch 2 times, most recently from 64ed3d8 to ff0f2ab Compare December 28, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@piranna