devices: Detect and extract data from J-Link #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #247 +/- ## ========================================== + Coverage 97.03% 97.07% +0.04% ========================================== Files 92 92 Lines 2729 2768 +39 ========================================== + Hits 2648 2687 +39 Misses 81 81
|
rwalton-arm requested changes Mar 31, 2021
When using J-Link, the only available board data may be the product page URL. The URL's slug may indicate the board, but not match the Mbed database slug, so this is searched against Mbed slug, board_type and board_name in the database to try to find a match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
When connecting with J-Link, some files we rely on for identifying the board may not be present. This adds parsers for
Segger.htmlandBoard.htmlfiles, and extracts the type of J-Link in use and the slug from the manufacturer's board URL. This slug will not always correspond to the Mbed slug, so an additional function is added to search for the matching board. This attempts to find a board in the database which matches any ofslug,board_nameorboard_typewith the extracted slug.Test Coverage