setup: Relax Click version requirement #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #246 +/- ## ======================================= Coverage 97.07% 97.07% ======================================= Files 92 92 Lines 2768 2768 ======================================= Hits 2687 2687 Misses 81 81 |
Patater reviewed Mar 30, 2021
rwalton-arm force-pushed the dev/rwalton-arm/unpin-click branch from 0f4b2a2 to 1aeb82b Compare We were pinning the version of Click we depend on to 7.1. Pinning to a specific version of the package is not ideal, as we would have to keep updating the pinned version to avoid dependency conflicts with newer Python packages that depend on later versions of Click. We depend on some Click features that appeared in 7.1, so we do need at least this version. Later versions of the package should also work for us, so we don't need to specify the requirement so precisely. This commit relaxes the requirement to Click 7.1 or greater and less than 8. This should minimise the potential for dependency conflicts with other packages. Fixes ARMmbed#245
rwalton-arm force-pushed the dev/rwalton-arm/unpin-click branch from 1aeb82b to 52fbd7e Compare Patater approved these changes Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
We were pinning the version of Click we depend on to 7.1. Pinning to a
specific version of the package is not ideal, as we would have to keep
updating the pinned version to avoid dependency conflicts with newer
Python packages that depend on later versions of Click. We depend on
some Click features that appeared in 7.1, so we do need at least this
version. Later versions of the package should also work for us, so we
don't need to specify the requirement so precisely.
This commit relaxes the requirement to Click 7.1 or greater. This should
minimise the potential for dependency conflicts with other packages.
Fixes #245
Test Coverage