Skip to content

Clean up date/time formatting code #6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Isira-Seneviratne wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Clean up date/time formatting code #6170

Isira-Seneviratne wants to merge 7 commits into from

Conversation

@Isira-Seneviratne
Copy link
Contributor

@Isira-Seneviratne Isira-Seneviratne commented Dec 7, 2025 •
edited
Loading

What does this do?

  • Cleans up the date/time formatting code by updating it to rely on the appropriate date/time formats for the current locale instead of manually specifying said formats where possible (formatting month day strings still requires the skeletons to be defined manually).
  • Remove some unused methods in DateUtil and add new formatting methods to reduce code duplication.

Why is this needed?

  • The current UI has some inconsistencies in its formatting of dates and times. This PR changes that so the appropriate formats will be used depending on the locale and system settings, e.g. whether 24-hour formatting is enabled or disabled.

Phabricator:
https://phabricator.wikimedia.org/T...

Screenshots

  • Article edit history

Before:
Screenshot_20251207-083745

After:
Screenshot_20251207-083801

  • Contributions

Before:
Screenshot_20251207-084131

After:
Screenshot_20251207-084139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Isira-Seneviratne @Williamrai