scriptHost fix #2246
Merged
scriptHost fix #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* for example when html-webpack-inline-source-plugin is used, the JS is inlined in HTML in script tag. So in this case document.currentScript.getAttribute('src') is undefined * undefined cannot be used as string with method replace. This cause a fatal error and crash app 
knagaitsev requested review from alexander-akait and hiroppy as code owners 6 tasks
Codecov Report
@@ Coverage Diff @@ ## master #2246 +/- ## ========================================= + Coverage 93.9% 93.9% +<.01% ========================================= Files 34 34 Lines 1279 1280 +1 Branches 367 368 +1 ========================================= + Hits 1201 1202 +1 Misses 71 71 Partials 7 7
Continue to review full report at Codecov.
|
| @Loonride Can we add tests? |
hiroppy approved these changes Sep 13, 2019
| @evilebottnawi |
rishabh3112 approved these changes Sep 15, 2019
alexander-akait approved these changes Sep 16, 2019
This was referenced Dec 14, 2019
This was referenced Feb 22, 2020
This was referenced Mar 13, 2020
This was referenced May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Pulled in changes from here and updated the test snapshot to fix CI: #2229
Breaking Changes
N/A
Additional Info