fix(config): Do not use config.renderStubDefaultSlot #1797
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Right now I've spent 30 minutes figuring why my default slots in stubs were not rendered, just to figure out, that our docs mention
global.renderStubDefaultSlot
as the way to control stub behavior, however we have bothconfig.renderStubDefaultSlot
andconfig.global.renderStubDefaultSlot
with first being a preferenceWhile technically this is a breaking change, I find an ability to define same thing in two places extremely confusing and fix for affected codebases will be trivial (swap
config.renderStubDefaultSlot
withconfig.global.renderStubDefaultSlot
)Otherwise, if we decide that we do not want to have such breaking change, I suggest swapping priority, so
config.global.renderStubDefaultSlot
will be taken into account beforeconfig.renderStubDefaultSlot
and markconfig.renderStubDefaultSlot
as deprecated