fix: Fix package.py commands after :zip not being executed #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sh commands after :zip were not being executed
mleziva changed the title mleziva changed the title mleziva changed the title 
Contributor Author
| @antonbabenko , can you please review when you get a chance. Thanks! |
antonbabenko requested changes Aug 19, 2024
Member
antonbabenko left a comment
antonbabenko left a comment There was a problem hiding this comment.
LGTM.
@pdecat what do you think?
antonbabenko approved these changes Aug 23, 2024
antonbabenko pushed a commit that referenced this pull request Aug 23, 2024
## [7.8.1](v7.8.0...v7.8.1) (2024-08-23) ### Bug Fixes * Fix package.py commands after :zip not being executed ([#606](#606)) ([801e69c](801e69c))
Member
| This PR is included in version 7.8.1 🎉 |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
When using the commands option in source_path, commands after ":zip" were not being executed. This PR resolves that unexpected behavior
Motivation and Context
The root cause was that the commands loop read all provided commands, but it didn't add the commands after a ":zip" command to the plan file. This was remediated by adding a check after the commands loop exited to add the remaining commands to the steps.
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request