fix: Dont raise FileNotFoundError from close() on tmpfile rename #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jjinno changed the title jjinno changed the title jjinno changed the title 
pdecat suggested changes Mar 15, 2024
check for file existence before fail-check Co-authored-by: Patrick Decat <pdecat@gmail.com>
pdecat reviewed Mar 19, 2024
| Thx. Ad astra! |
antonbabenko pushed a commit that referenced this pull request Mar 29, 2024
## [7.2.4](v7.2.3...v7.2.4) (2024-03-29) ### Bug Fixes * Dont raise FileNotFoundError from close() on tmpfile rename ([#550](#550)) ([58ba987](58ba987))
| This PR is included in version 7.2.4 🎉 |
| It looks like something wrong: It will raise an exception!!! |
| I'm going to add python lint checks to CI to catch this sort of mistakes. |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Allow
FileNotFoundErrorto be ignored onclose()to compensate for file already being renamedMotivation and Context
There appear to be some conditions by which the
self._tmp_filenamefile has already been renamed/moved toself.filenameprior to (or racing with) the calling ofclose().In this case
FileNotFoundErrorwill be thrown, causing the Terraform to fail. But without changing anything, a subsequent run of the Terraform will succeed because the ZIP file already exists. (aka: it was created correctly on the first pass)Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request