fix: Fixed npm install on Windows without having to use wsl #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
antonbabenko changed the title antonbabenko pushed a commit that referenced this pull request Oct 5, 2023
### [6.0.1](v6.0.0...v6.0.1) (2023-10-05) ### Bug Fixes * Fixed npm install on Windows without having to use wsl ([#502](#502)) ([ffa56e8](ffa56e8))
Member
| This PR is included in version 6.0.1 🎉 |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Use of npm.cmd on WINDOWS instead of npm within install_npm_requirements method
Motivation and Context
#414 describes the issue, it has been closed with the resolution that WSL should be used. While this is a solution not all development teams use WSL. Additionally, the package.py already contains specific WINDOWS handling anyway (e.g. for python).
Fixes #414
Breaking Changes
no breaking change imho
How Has This Been Tested?
locally on my Windows machine.