fix: Lambda should depend on policy attachments #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
x539 changed the title x539 changed the title 
When the lambda is created the execution-role with all its policies should be in place. Some policies like VPC are a hard requirement for lambda creation which fill fail if they are not already in place.
x539 force-pushed the fix-lambda-creation-dependencies branch from 47cd415 to 01cfe9c Compare 
| Appreciate the fix. I am having the same issue. |
| The same applies if you destroy the stack. First, the policies are then removed, which means that the Lambda no longer has rights to remove the ENIs and Terraform therefore cannot remove the security group because it is still "in-use" by these ENIs. |
antonbabenko changed the title 
antonbabenko approved these changes Sep 1, 2022
antonbabenko pushed a commit that referenced this pull request Sep 1, 2022
### [4.0.1](v4.0.0...v4.0.1) (2022-09-01) ### Bug Fixes * Lambda should depend on policy attachments ([#327](#327)) ([b4eef74](b4eef74))
| This PR is included in version 4.0.1 🎉 |
| I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Added all policy-attachments to the deponds_on of the 'aws_lambda_function'
Motivation and Context
When the lambda is created the execution-role with all its
policies should be in place.
Some policies like VPC are a hard requirement for lambda creation
which fill fail if they are not already in place.
Fixes #326
Breaking Changes
May introduce circular dependencies, where policies some how depend on the lambda.
Those policies could created / attached outside of this module.
How Has This Been Tested?
examples/with-vpcpre-commit run -aon my pull request