Decouple InferenceSession lifecycle from Predict #10
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As per #8 I would like to propose some (breaking) changes to your Scorer api/package.
After this PR, the InferenceSession is only created once per YoloScorer instance. Creating a session is relative expensive and when doing a lot of inferences I would like to reuse this session.
I've updated the constructor of the YoloScorer to take two parameters.
new SessionOptions().The YoloScorer now implements IDisposable as it owns the lifecycle of InferenceSession and SessionOptions which are IDisposable.
I've changed the paths from
assetstoAssetsas paths are case-sensitive on Linux.Let me know if you agree with these changes. Happy to discuss further changes.