[Console] fix section output when multiples section with max height #51355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
joelwurtz force-pushed the fix/multiple-section-max-height branch from 1ffffc2 to 4fe2c53 Compare 
joelwurtz commented Aug 11, 2023
| $expected .= 'Two'.\PHP_EOL.'Three'.\PHP_EOL.'Four'.\PHP_EOL; | ||
| | ||
| rewind($this->stream); | ||
| $this->assertEquals(escapeshellcmd($expected), escapeshellcmd(stream_get_contents($this->stream))); |
There was a problem hiding this comment.
escallesshellcmd is intended here, it's way better to debug output with this, as we can properly see escaped character when there is a failure :
joelwurtz force-pushed the fix/multiple-section-max-height branch from 4fe2c53 to 28e9da6 Compare 
lyrixx approved these changes Aug 11, 2023
stof approved these changes Aug 11, 2023
fabpot approved these changes Aug 12, 2023
| Thank you @joelwurtz. |
Merged
renovate bot added a commit to Lendable/composer-license-checker that referenced this pull request Aug 26, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [symfony/console](https://symfony.com) ([source](https://togithub.com/symfony/console)) | require | patch | `6.3.2` -> `6.3.4` | | [symfony/process](https://symfony.com) ([source](https://togithub.com/symfony/process)) | require | patch | `6.3.2` -> `6.3.4` | --- ### Release Notes <details> <summary>symfony/console (symfony/console)</summary> ### [`v6.3.4`](https://togithub.com/symfony/console/releases/tag/v6.3.4) [Compare Source](https://togithub.com/symfony/console/compare/v6.3.2...v6.3.4) **Changelog** (symfony/console@v6.3.3...v6.3.4) - bug [symfony/symfony#51378](https://togithub.com/symfony/symfony/issues/51378) \[Console] avoid multiple new line when message already ends with a new line in section output ([@​joelwurtz](https://togithub.com/joelwurtz)) - bug [symfony/symfony#51223](https://togithub.com/symfony/symfony/issues/51223) \[Console] Fix linewraps in `OutputFormatter` (@​maxbeckers) - bug [symfony/symfony#51355](https://togithub.com/symfony/symfony/issues/51355) \[Console] fix section output when multiples section with max height ([@​joelwurtz](https://togithub.com/joelwurtz)) </details> <details> <summary>symfony/process (symfony/process)</summary> ### [`v6.3.4`](https://togithub.com/symfony/process/compare/v6.3.2...v6.3.4) [Compare Source](https://togithub.com/symfony/process/compare/v6.3.2...v6.3.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/composer-license-checker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pr does not fix #35012
However it fixes the second script wrote by @lyrixx (#35012 (comment)) with fiber and parallel output.
In short when there was multiple sections with max height, it was not taking into account the max height of other sections when doing a full rewrite, leading to erase more lines than intended.