Refactoring SwiftMemcache #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
FranzBusch reviewed Sep 14, 2023
Package.swift Outdated
| dependencies: ["Memcache"] | ||
| ), | ||
| .executableTarget( | ||
| name: "swift-memcache-gsoc-example", |
There was a problem hiding this comment.
Can we rename this to MemcacheExample
README.md Outdated
| | ||
| ## Getting Started | ||
| | ||
| ### Docker |
There was a problem hiding this comment.
Can we move this to a Contributing section. This is not relevant for users of the package.
| @@ -12,7 +12,11 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
| | |||
| import Foundation | |||
There was a problem hiding this comment.
Can we rename the file as well
dkz2 force-pushed the Memcache-Cleanup branch from 3595df2 to f3aba8e Compare FranzBusch reviewed Sep 19, 2023
| @@ -0,0 +1,72 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
We shouldn't commit this
| @@ -0,0 +1,140 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -0,0 +1,104 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
README.md Outdated
| | ||
| ### Memcached Connection API | ||
| | ||
| Our `MemcachedConnection` allows for communicate with a Memcached server. This actor takes care of establishing a connection, creating a request stream and handling asynchronous execution of commands. |
There was a problem hiding this comment.
It is now MemcacheConnection right?
FranzBusch approved these changes Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR addresses the need to align the library with Memcache naming conventions and to remove any unnecessary dependences. This PR closes #39.
Motivation:
To adhere to industry standard naming conventions by renaming types to be
memcachei.e without thememcache/d.Modifications:
Memcachedto now useMemcahce.Results:
With these changes the library is better aligned with Memcache naming conventions, making it more recognizable and idiomatic to the community.