Implement Add and Replace support #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
FranzBusch requested changes Aug 6, 2023
| | ||
| // MARK: - Adding a Value | ||
| | ||
| /// Adds a value to a new key in the Memcached server. |
There was a problem hiding this comment.
Suggested change
| /// Adds a value to a new key in the Memcached server. | |
| /// Adds a new key-value pair in the Memcached server. |
Tests/SwiftMemcacheTests/IntegrationTest/MemcachedIntegrationTests.swift Show resolved Hide resolved
Tests/SwiftMemcacheTests/IntegrationTest/MemcachedIntegrationTests.swift Show resolved Hide resolved
| } | ||
| } | ||
| | ||
| func testReplaceValue() async throws { |
There was a problem hiding this comment.
Can we have a test where the key/value pair doesn't exist yet
FranzBusch approved these changes Aug 7, 2023
Comment on lines +360 to +361
| if "\(error)" != "keyNotFound" { | ||
| throw error |
There was a problem hiding this comment.
Yeah we really need to work on better public errors so we allow users to catch this without relying on the string description of the error. Let's create an issue for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR addresses the need to enhance our Memcache functionality with
addandreplaceoperation support. These operations enable modifying key-value pairs by providing a more granular level of control over how data is stored. This PR closes #25.Motivation:
To improve our interactions with memcached servers in a more dynamic and versatile way.
AddandReplaceoperations not only increase cache efficiency by minimizing network round trips for data modification but also broadens our API capabilities.Modifications:
addandreplacemethods toMemcachedConnection.StorageModeenum to handleaddandreplacestate.Result:
With the addition of
addandreplacesupport, our API now allows users to add and modify data in the cache directly, improving cache efficiency and expanding the versatility of our API.