Skip to content

Implement a get request #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 6, 2023
Merged

Implement a get request #14

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
87d1682
init get request structure
dkz2 Jun 7, 2023
186088c
re work MemcachedFlags model
dkz2 Jun 14, 2023
d772994
dataLengthOrFlag split + readMemcachedFlags
dkz2 Jun 15, 2023
1bdd64d
decoder pr refactors
dkz2 Jun 24, 2023
e3a764c
write and read memcached flag fixes
dkz2 Jun 27, 2023
c2e774f
combine flag states into one
dkz2 Jun 28, 2023
bafe676
data length is written as text not encoded as UInt64
dkz2 Jun 28, 2023
923cf2b
remaining PR changes
dkz2 Jun 29, 2023
423d8f9
optimized dataLength read by fixing readIntegerFromASCII
dkz2 Jun 30, 2023
48772a6
removed flagToByte prop
dkz2 Jun 30, 2023
79b653f
final clean up closes #6
dkz2 Jun 30, 2023
9056f40
flag state clean up + set up for partial buffers impl to come soon
dkz2 Jul 6, 2023
118b029
closes #6
dkz2 Jul 6, 2023
6bad1ff
ensure we have \r\n before parsing
dkz2 Jul 6, 2023
437783a
\r\n + partial/split buffer test
dkz2 Jul 6, 2023
bfb446a
closes #6
dkz2 Jul 6, 2023
bc1b03b
.suffix(2) is costly removed it
dkz2 Jul 6, 2023
4288843
walk buffer to find first \r\n
dkz2 Jul 6, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
final clean up closes #6
  • Loading branch information
@dkz2
dkz2 committed Jun 30, 2023
commit 79b653f6a3a5fc367f1971c89e8930dfbba913a4
2 changes: 1 addition & 1 deletion Sources/SwiftMemcache/MemcachedResponseDecoder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ struct MemcachedResponseDecoder: NIOSingleStepByteToMessageDecoder {
case dataLength(MemcachedResponse.ReturnCode)
/// Decode the flags
case flags(MemcachedResponse.ReturnCode, UInt64?)
Copy link
Contributor

@FranzBusch FranzBusch Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename this to decodeFlag and always try to decode a single flag at a time. We just have to update the flags struct and store it as a state here.

Suggested change
case flags(MemcachedResponse.ReturnCode, UInt64?)
case flags(MemcachedResponse.ReturnCode, UInt64?)
// TODO: Add a next step for decoding the response data if the return code is VA
/// Decode the Value
case decodeValue(MemcachedResponse.ReturnCode, UInt64, MemcachedFlags?)
Copy link
Contributor

@FranzBusch FranzBusch Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need an optional for flags here we can just always have it since all its field are optional
}

Expand Down