Skip to content

Conversation

@jerm-dro
Copy link
Contributor

Summary

Fix a bug where broken config plumbing lead to ignored continue-on-error behavior in composite tools.

Details

While preparing for a demo of continue-on-error behavior, I encountered a surprising bug where my config for a skippable step was not respected.

 on_error: action: "continue" # Continue workflow despite error

Instead, the composite tool aborted.

Root Cause

This was a surprising bug, because I know an integration test exists. Upon closer inspection, you'll see our integration tests bypass much of our configuration plumbing, previously described here. The composite tools system is even more elaborate, since it has another step:
CRD config -> yaml -> rawConfig -> config -> data structures used in execution
The linked integration tests configures data structures used in execution, so it missed the broken config -> data structures used in execution step.

I chose not to write a regression test for this quick fix. Instead, I will be opening an issue that describes the systemic issue and breakdown the work to repair it.

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.09%. Comparing base (fd06526) to head (4e198c7).

Additional details and impacted files
@@ Coverage Diff @@ ## main #3118 +/- ## ========================================== - Coverage 57.10% 57.09% -0.01%  ========================================== Files 341 341 Lines 33940 33941 +1 ========================================== - Hits 19381 19380 -1  - Misses 12956 12958 +2  Partials 1603 1603 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 20, 2025
@jerm-dro jerm-dro mentioned this pull request Dec 20, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

2 participants