Fixes initialization of UASTViewer #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There are two problems: 1. `UASTViewerPane` checks only for `flatUast` and not `initialFlatUast`. This means that it can work only when the `uast-viewer` is used in *controlled mode*. This has been fixed by checking `flatUast` first and then fallback to `initialFlatUast`. 2. `UASTViewer` component needs to be in *uncontrolled mode*, so it needs to use `initialFlatUast`. This has ben fixed by renaming `flatUast` into `initialFlatUast`. Signed-off-by: Lou Marvin Caraig <loumarvincaraig@gmail.com>
smacker approved these changes Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #402.
There are two problems:
UASTViewerPanechecks only forflatUastand notinitialFlatUast. This means that it can work only when theuast-vieweris used in controlled mode. This has been fixed bychecking
flatUastfirst and then fallback toinitialFlatUast.UASTViewercomponent needs to be in uncontrolled mode, so itneeds to use
initialFlatUast. This has ben fixed by renamingflatUastintoinitialFlatUast.