Skip to content

Conversation

@se7entyse7en
Copy link
Contributor

Kind of related to this.

I hadn't run dep ensure -update in that PR.

Signed-off-by: Lou Marvin Caraig <loumarvincaraig@gmail.com>
@carlosms
Copy link
Contributor

I wonder why there are updates if we are using dependabot to keep up to date.

@se7entyse7en
Copy link
Contributor Author

mhmmm... I didn't think about dependabot, but yup I'd expect the changes to involve only go-client, but it seems that a lot of other things have changed.

@carlosms
Copy link
Contributor

I'm not sure if upgrading this many things at once is risky. Did you go over the release notes?

@se7entyse7en
Copy link
Contributor Author

Sorry, maybe I still didn't understand dep too. But AFAIU dep ensure updates vendor from Gopkg.toml and Gopkg.lock, but to update Gopkg.lock we have to run dep ensure -update. So didn't we need to always run dep ensure -update every time we add a dependency?

@se7entyse7en
Copy link
Contributor Author

Now one thing that I don't understand is why here the vendor doesn't have any updates.

@se7entyse7en
Copy link
Contributor Author

Now one thing that I don't understand is why here the vendor doesn't have any updates.

Oh ok I realized that go-client was already present in vendor.

@smacker
Copy link
Contributor

smacker commented Apr 18, 2019

dep ensure -update 

updates all the dependencies

dep ensure -update package 

updates only one package.

$ dep ensure --help ... -update update the named dependencies (or all, if none are named) in Gopkg.lock to the latest allowed by Gopkg.toml (default: false) 
@se7entyse7en
Copy link
Contributor Author

se7entyse7en commented Apr 18, 2019

Okay I also realized that this

Now one thing that I don't understand is why here the vendor doesn't have any updates.

wasn't true, it's clear that the package in vendor has been renamed. Okay gonna close this! 👍 Sorry for the mess.

Thanks @smacker.

@se7entyse7en se7entyse7en deleted the missing-ensure-update branch April 18, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants