fix(engine/sqlite): added json_tree and json_each definitions #4054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dosubot bot added size:XXL 
alixinne force-pushed the fix/1830-json-each branch 2 times, most recently from c228645 to 03a1e5f Compare 
alixinne force-pushed the fix/1830-json-each branch from 03a1e5f to 8186938 Compare 
| @alixinne I have some larger plans for the SQLite engine that give us support for these features automatically. That means I'm going to hold off on reviewing / merging this right now. Thanks for understanding. |
That's good news, is there some kind of tracking issue for this I could subscribe to in order to follow along? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #1830
This is a rebased version of @orisano's PR #2570. I've hit the same bug, and the fix in the PR does work in my case. I have removed the PostgreSQL tests changes as they look obsolete / not affected by the bugfix, so it's only focused on the sqlite code generation.
cc. @andrewmbenton and/or @kyleconroy for a review?