feat(create-web-scripts-library): implement cli and script #20
Conversation
fastfrwrd force-pushed the fix-11 branch 8 times, most recently from 5bb650e to 3a1f15f Compare 
| ### With `yarn create` | ||
| | ||
| ```sh | ||
| yarn create @spotify/web-scripts-library my-cool-library |
There was a problem hiding this comment.
yarn somehow knows where to inject the create?
| | ||
| ```sh | ||
| npm i -g @spotify/web-scripts-create-library | ||
| web-scripts-create-library my-cool-library |
There was a problem hiding this comment.
I'd prefer if we avoided promoting a global install, they tend to lead to nothing but pain!
There was a problem hiding this comment.
it's a fact. happy to remove it, people can figure it out on their own if they really need it
kirbysayshi left a comment
kirbysayshi left a comment There was a problem hiding this comment.
Some small comments, but looks really good!
| "extends": "@spotify/web-scripts/config/tsconfig.json", | ||
| "include": ["src"], | ||
| "compilerOptions": { | ||
| "incremental": true, |
There was a problem hiding this comment.
This should probably be the default in the base config!
| "incremental": true, | ||
| "isolatedModules": false, | ||
| "noEmit": true, | ||
| "declaration": false, |
There was a problem hiding this comment.
for both noEmit and declaration, doesn't web-scripts handle these flags? I don't think we should imply they need to be managed by repeating them here.
There was a problem hiding this comment.
huh, I have no clue why I have these differences like this. Will clear them out.
Why: in lieu of an
initscript like Storybook does, this simpler path to create a scaffolded app using https://github.com/spotify/web-scripts-library-template in the style of create-next-app or create-react-app. This also means you don't need to ship any of the scaffolding deps (such as fs-extra) with web-scripts.Fixes #11