This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Increased default maxWait - for Serial #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit increases the default maxWait.
The default value of 250ms works perfectly well on I2C / Qwiic, but I see regular failures when using Serial. Some calls take a full second to be processed correctly.
isConnected now includes maxWait as a parameter too. I was seeing begin fail when using Serial. begin calls isConnected when then calls sendCommand. And the default maxWait of 250ms was causing problems.