Arduino modification #99
Conversation
Changed from byte to integer for analog read
| Thanks for following our tutorial! I'm going to close this out to leave the repo usable for others, but let us know if you have any questions! |
| I didn't know I had it open for this long, can you teach me the proper way to use this so I can ensure that others can use the repo? …On Tue, Dec 20, 2016 at 6:15 PM, Toni Klopfenstein ***@***.*** > wrote: Closed #99 <#99>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#99 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATrCzRUUR1C1YXgc3a7MGJwBNsqnx9vqks5rKG-pgaJpZM4JTp1S> . |
| Hi @chiomaso - you didn't do anything incorrectly on this. What I meant when I said I was closing out your pull request to leave the repo functional for others is simply that if I accepted your pull request, it would fix the error in the code that our tutorial is based around. If the error is no longer there, the repo would not be a useful teaching tool for others following along with the tutorial. However, in a regular GitHub project (not a demo repo like this), I would have absolutely accepted your pull request, which would also automatically close this out, but only after making the changes to the code that you were offering. I hope that clarifies! |
2 participants
Changed from byte to integer for analog read