Generated updated questions json and commit #205
Conversation
leo-step commented Jul 31, 2022
leo-step commented - Store question data in json format
- Cron job script reads and updates questions json
- Sets "updated" field to current datetime
- Commits the changes back into the repository
There was a problem hiding this comment.
You're on a roll @leo-step! Thank you once again for helping implement this - I know it'll definitely be appreciated by others for sure.
Everything is looking good - I think we should handle the case where questions.json isn't able to be opened/read.
cron/update_questions.py Outdated
| | ||
| for question in questions["data"]: | ||
| p = urlparse(question["url"]) | ||
| title_slug = p.path.rstrip('/').split('/')[-1] |
There was a problem hiding this comment.
I think that it probably makes more sense to just have the slug for url since each URL is prefixed with https://leetcode.com/problems/
cron/update_questions.py Outdated
| for question in questions: | ||
| print("Reading questions file") | ||
| | ||
| with open("questions.json", "r") as file: |
There was a problem hiding this comment.
I think it makes sense to have an except clause incase questions.json can't be opened/found
cron/update_questions.py Outdated
| | ||
| their_difficulty = response.json()["data"]["question"]["difficulty"] | ||
| | ||
| if their_difficulty != our_difficulty: |
There was a problem hiding this comment.
| if their_difficulty != our_difficulty: | |
| if leetcode_difficulty != our_difficulty: |
Could we make this small change here and in other relevant places? I think it'll help make reading the code a little easier!
2 participants
