Skip to content

implement filtering by completion status #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2022
Merged

implement filtering by completion status #180

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df58082
implement filter dropdown based on checkbox
leo-step Jul 23, 2022
5b02819
move local storage access out of filter function
leo-step Jul 23, 2022
4073748
clean up function
leo-step Jul 23, 2022
9797bf5
move difficulty map code so it gets computed properly
leo-step Jul 23, 2022
98a9cdc
Revert "clean up function"
leo-step Jul 23, 2022
9b5d637
replace br with css
leo-step Jul 25, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up function
  • Loading branch information
@leo-step
leo-step committed Jul 23, 2022
commit 4073748fceb345eee7379e3a993512f772b3f765
6 changes: 2 additions & 4 deletions src/components/Table/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ const Table = () => {

const filteredByCheckbox = () => {
const checkbox = localStorage.getItem('checkbox') || '';
return questions.filter(question => {
if (!checkbox) return true;
return question.checkbox === checkbox;
});
if (!checkbox) return questions;
return questions.filter(q => q.checkbox === checkbox);
};

for (let i = 0; i < questions.length; i += 1) {
Expand Down