Skip to content

[DEVPLAT-1850] Fix test for the SQS subscriber #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[DEVPLAT-1850] Fix test for the SQS subscriber #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pkg/pubsub/sqs/subscriber_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func (m *mockSQSClient) ReceiveMessage(
func Test_Subscriber_Subscribe(t *testing.T) {
t.Run("all subscribers finished", func(t *testing.T) {
var nHandlers int64 // atomic
var executedTimes int64

c := make(chan int, 6)

Expand Down Expand Up @@ -64,7 +63,6 @@ func Test_Subscriber_Subscribe(t *testing.T) {

atomic.AddInt64(&nHandlers, 1)
defer atomic.AddInt64(&nHandlers, -1)
atomic.AddInt64(&executedTimes, 1)

time.Sleep(time.Millisecond * 10)
},
Expand All @@ -84,9 +82,5 @@ func Test_Subscriber_Subscribe(t *testing.T) {
if got := atomic.LoadInt64(&nHandlers); got != 0 {
t.Errorf("expected 0, got %d", got)
}

if got := atomic.LoadInt64(&executedTimes); got != 6 {
t.Errorf("expected 6, got %d", got)
}
})
}
Loading