Skip to content

Fix for #53 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for #53 #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 13 additions & 22 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export class ScrollBottomSheet<T extends any> extends Component<Props<T>> {
private lastStartScrollY: Animated.Value<number> = new Value(0);
private prevTranslateYOffset: Animated.Value<number>;
private translationY: Animated.Value<number>;
private destSnapPoint = new Value(0);
private destSnapPoint = new Value<number>(0);

private lastSnap: Animated.Value<number>;
private dragWithHandle = new Value(0);
Expand Down Expand Up @@ -558,6 +558,7 @@ export class ScrollBottomSheet<T extends any> extends Component<Props<T>> {
set(this.dragWithHandle, 0),
]),
set(this.isManuallySetValue, 0),
set(this.nextSnapIndex, 0),
set(this.manualYOffset, 0),
stopClock(clock),
this.prevTranslateYOffset,
Expand Down Expand Up @@ -670,8 +671,18 @@ export class ScrollBottomSheet<T extends any> extends Component<Props<T>> {
snapTo = (index: number) => {
const snapPoints = this.getNormalisedSnapPoints();
this.isManuallySetValue.setValue(1);
this.manualYOffset.setValue(snapPoints[index]);
const yOffset = snapPoints[index];
this.manualYOffset.setValue(yOffset);
this.nextSnapIndex.setValue(index);

this.destSnapPoint.setValue(yOffset);
this.animationFinished.setValue(0);
this.lastSnap.setValue(yOffset);
// This is the TapGHandler trick
// @ts-ignore
this.masterDrawer?.current?.setNativeProps({
maxDeltaY: yOffset - this.getNormalisedSnapPoints()[0],
});
};

render() {
Expand Down Expand Up @@ -828,26 +839,6 @@ export class ScrollBottomSheet<T extends any> extends Component<Props<T>> {
])
)}
/>
<Animated.Code
exec={onChange(this.isManuallySetValue, [
cond(
this.isManuallySetValue,
[
set(this.destSnapPoint, this.manualYOffset),
set(this.animationFinished, 0),
set(this.lastSnap, this.manualYOffset),
call([this.lastSnap], ([value]) => {
// This is the TapGHandler trick
// @ts-ignore
this.masterDrawer?.current?.setNativeProps({
maxDeltaY: value - this.getNormalisedSnapPoints()[0],
});
}),
],
[set(this.nextSnapIndex, 0)]
),
])}
/>
</Animated.View>
);

Expand Down