-
-
Couldn't load subscription status.
- Fork 3.3k
Add size-limit config #2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add size-limit config #2173
Conversation
| This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| Honestly, I'm not a huge fan of these sorts of tools. They tend to be more annoying than helpful. Maybe we can limit it to just a Edit: Wait, don't we already have this? https://github.com/reduxjs/react-redux/blob/master/.github/workflows/size.yaml |
That's fair, but
While The idea is to have this here so that if we were ever to make a set of changes, we could use it to keep an eye on bundle sizes, it doesn't necessarily have to put a "limit" on anything. |
| yeah, while I don't think the concept of a size "limit" is very useful, I do find it useful to have visibility on how a given set of changes affects final bundle size. |
| Could this supplant our usage of compressed-size-action? That one hasn't been updated in a long time and causes some warnings in CI that will eventually turn into errors, so it's been on my radar to replace it. |
| I guess we could use https://github.com/EskiMojo14/size-limit-action, same thing we're doing with RTK. |
✅ Deploy Preview for react-redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
97056ad to bef6ea4 Compare | Yeah, I think we want to switch to the other size package for consistency. |
| The other size package? |
| https://github.com/EskiMojo14/size-limit-action , per above |
c1b6e60 to 424ba39 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
424ba39 to f860d98 Compare 55722a5 to dec351d Compare 79a6b68 to 00f344a Compare 00f344a to d32cf69 Compare d32cf69 to 8a6da3a Compare 4abd8a3 to 8b5ecee Compare | Can we just merge this at this point? I don't need another resolution for 2025 😂 |
| @aryaemami59 same question as with the RTK PR - what does the actual output look like atm? |
8b5ecee to 0f8e814 Compare 0f8e814 to ff5126d Compare ff5126d to 2035697 Compare d9e338c to 9210fde Compare 9210fde to e419a2a Compare e419a2a to c5eff72 Compare - Cut down on `size-limit` config to not go through every single entry point.
c5eff72 to 5ebfd08 Compare 5ebfd08 to ba4faa6 Compare
This PR:
size-limitconfig to monitor bundle size changes in preparation for any potential changes we'll have to make to migrate to React 19.