Skip to content

fixed package.json warnings #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2021
Merged

fixed package.json warnings #22

merged 4 commits into from
Oct 11, 2021

Conversation

@vishal5251
Copy link
Contributor

@vishal5251 vishal5251 commented Oct 10, 2021

source: package.json, package-lock.json
fixed npm install warnings.
@vishal5251
Copy link
Contributor Author

vishal5251 commented Oct 10, 2021

closes #22
my twitter handle is @VishalJ95917351
SuzeShardlow
SuzeShardlow suggested changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@SuzeShardlow SuzeShardlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishal5251!

I have reviewed this and will require one small change before I can approve and merge it. In issue #21, we asked "please do not update the version of the "redis" package used by this project, it should remain at "^2.8.0"". I have noticed that you have changed the Redis version. It needs to stay at 2.8.0 because this is the version that the training course is based around.
@vishal5251
Copy link
Contributor Author

vishal5251 commented Oct 11, 2021

close #22
@vishal5251
Revert "fixed"
fcc2979 
This reverts commit 4725b02.
SuzeShardlow
SuzeShardlow approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@SuzeShardlow SuzeShardlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vishal5251, thank you for making the requested changes. I am happy to merge this.
@SuzeShardlow
Copy link
Contributor

SuzeShardlow commented Oct 11, 2021

Thanks, @vishal5251! If you are a member of our Discord (https://discord.com/invite/ueQwKUh5Z3), please drop your handle here and we will give you the Hacktoberfest 2021 role :) and if you'd like a shout out on Twitter, drop your handle!
@SuzeShardlow SuzeShardlow merged commit 88f8488 into redislabs-training:master Oct 11, 2021
@SuzeShardlow SuzeShardlow added the hacktoberfest-accepted Accepted for Hacktoberfest 2021 label Oct 11, 2021
@vishal5251
Copy link
Contributor Author

vishal5251 commented Oct 11, 2021

Thanks, @vishal5251! If you are a member of our Discord (https://discord.com/invite/ueQwKUh5Z3), please drop your handle here and we will give you the Hacktoberfest 2021 role :) and if you'd like a shout out on Twitter, drop your handle!

You're most welcome, vishal5251 is my discord username and @VishalJ95917351 is my twitter one. Thanks!
gonzaldd pushed a commit to gonzaldd/redis-ru102js that referenced this pull request Mar 4, 2023
@SuzeShardlow
Merge pull request redislabs-training#22 from vishal5251/dev
d57832f 
fixed package.json warnings Closes redislabs-training#21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted for Hacktoberfest 2021

3 participants

@vishal5251 @SuzeShardlow @simonprickett