Skip to content

Conversation

@LuizHAP
Copy link
Contributor

@LuizHAP LuizHAP commented Oct 9, 2021

#18 fix.

When uploading this code to the master, switch to use the github link inside the .github folder in the blob

Copy link
Contributor

@SuzeShardlow SuzeShardlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LuizHAP! Thanks for your contribution. This is a great start!

  1. I noticed that the screen grab has been cropped at the bottom. Could you get another one please? See the README for the Python course as an example:

https://github.com/redislabs-training/ru102py

  1. I also noticed that you saved your image in a new directory and that it is hosted by a third party service. Therefore, please save the screen grab in the root of this repo and then link directly to it. Again, see the Python README for an example of how to do this.

Once you have done the above, I will be happy to approve.

Thanks!

@LuizHAP
Copy link
Contributor Author

LuizHAP commented Oct 10, 2021

@SuzeShardlow and @simonprickett i think now its fixed

Copy link
Contributor

@SuzeShardlow SuzeShardlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @LuizHAP! I will add the label and merge this :)

@SuzeShardlow
Copy link
Contributor

Thanks, @LuizHAP! If you are a member of our Discord (https://discord.com/invite/ueQwKUh5Z3), please drop your handle here and we will give you the Hacktoberfest 2021 role :) and if you'd like a shout out on Twitter, drop your handle!

@SuzeShardlow SuzeShardlow added the hacktoberfest-accepted Accepted for Hacktoberfest 2021 label Oct 10, 2021
@SuzeShardlow SuzeShardlow merged commit 3a8bab2 into redislabs-training:master Oct 10, 2021
@LuizHAP
Copy link
Contributor Author

LuizHAP commented Oct 11, 2021

Yee!! Great!

My twitter https://twitter.com/NerdThingsBR and my discord Ozzymosis#5303

@simonprickett
Copy link

@LuizHAP :) I've given you the Hacktoberfest 2021 role on our Discord, so that the community can see you're a contributor.

@LuizHAP LuizHAP deleted the feature/readme-changes branch October 11, 2021 12:05
gonzaldd pushed a commit to gonzaldd/redis-ru102js that referenced this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted for Hacktoberfest 2021

3 participants