Skip to content

Conversation

@acogoluegnes
Copy link
Contributor

References #379

@acogoluegnes acogoluegnes force-pushed the micrometer-observation branch from 8e3866c to 8bc3f77 Compare July 25, 2023 13:45
@acogoluegnes acogoluegnes marked this pull request as ready for review July 26, 2023 13:42
@acogoluegnes
Copy link
Contributor Author

@marcingrzejszczak Feel free to have a look. Thanks!

@acogoluegnes
Copy link
Contributor Author

@acogoluegnes acogoluegnes force-pushed the micrometer-observation branch from d1f8c72 to 82a57ab Compare July 28, 2023 08:28
Copy link

@marcingrzejszczak marcingrzejszczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the changes and they look great! Do you have a Zipkin screenshot from the tests?

Add method to annotate a created message.
Type parameter is the context, e.g. Observation for Micrometer. References #379
When a message is routed to several streams in a super stream producer. References #379
Test with 2 supported codecs. Test a message without tracing info is consumed correctly. References #379
@acogoluegnes acogoluegnes force-pushed the micrometer-observation branch from 82a57ab to 1e7c1c2 Compare August 29, 2023 08:02
@acogoluegnes
Copy link
Contributor Author

@marcingrzejszczak Here you go:

image

Does that look good to you?

@marcingrzejszczak
Copy link

LGTM

@acogoluegnes acogoluegnes merged commit 11ec03e into main Aug 29, 2023
@acogoluegnes acogoluegnes deleted the micrometer-observation branch August 29, 2023 09:18
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants