Skip to content

Conversation

@radarhere
Copy link
Member

Helps #4193 with a different approach - rather than converting individual files completely, this PR changes single assert lines.

@hugovk
Copy link
Member

hugovk commented Feb 22, 2020

And do the rest of the conversion in follow-up PRs? It's a bit more churny, but sure.

Perhaps omit test_file_bmp.py and test_file_im.py from here, as they have full conversion in #4424?

@radarhere
Copy link
Member Author

I just thought it was an easier way to approach the repetitive task of conversion.

Okay, omitted those files.

@hugovk
Copy link
Member

hugovk commented Feb 22, 2020

I restarted the failed AppVeyor builds after a network error:

Build started ECHO %PYTHON% C:/Python38-x64 git clone -q https://github.com/python-pillow/Pillow.git c:\pillow git fetch -q origin +refs/pull/4443/merge: git checkout -qf FETCH_HEAD Restoring build cache Cache 'C:\Users\appveyor\AppData\Local\pip\Cache' - Restored Running Install scripts curl -fsSL -o pillow-depends.zip https://github.com/python-pillow/pillow-depends/archive/master.zip curl: (18) transfer closed with outstanding read data remaining Command exited with code 18 

If it happens again, we can look to hardening the curl.

@hugovk hugovk merged commit dab94e6 into python-pillow:master Feb 22, 2020
@radarhere radarhere deleted the assert branch February 22, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants