Fix Name field length when saving IM images #4424
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For #4193.
Converting
Tests/test_file_im.pyto use pytest surfaced a bug in saving IM format files.When roundtripping the file, it failed opening the saved file, at this check:
Pillow/src/PIL/ImImagePlugin.py
Lines 155 to 156 in 29fee8f
It's falling over the
Name:field, which is saved like this:Pillow/src/PIL/ImImagePlugin.py
Lines 349 to 350 in 29fee8f
The difference is the temp path+filename under the limit with
PillowTestCase.tempfile:And over the limit with pytest's
tmp_path:This PR trims the path+filename to fit, and I suggest to keep the last part which includes the filename and extension, rather than cropping it off.